This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
Allow the secret to be safely specified externally #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the code is written today expects users to modify the file that's under the version control system. This is inherently dangerous as a developer needs to locally edit this file and then be very careful not to accidentally commit the change in to the repository. A better way to do this is to either allow these constants to be defined through a compiler switch (for interactive dekstop development) or in a separate file (outside the ForcePad source tree and the -I option allows you to have this import statement resolve the header file correctly.) This will also work better in a build server, where an in-place modification to a file is tricky.
|
Thanks for this! A great improvement. Unfortunately I'm no longer at salesforce and no one there is maintaining ForcePad. I can't merge this request, but leaving it open should let others see it and use your fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the code is written today expects users to modify the file
that's under the version control system. This is inherently dangerous as
a developer needs to locally edit this file and then be very careful not
to accidentally commit the change in to the repository.
A better way to do this is to either allow these constants to be defined
through a compiler switch (for interactive dekstop development) or in a
separate file (outside the ForcePad source tree and the -I option allows
you to have this import statement resolve the header file correctly.)
This will also work better in a build server, where an in-place
modification to a file is tricky.